Talk:Artifacts - Revision history

imported>Cooperka: /* Fixing some off-by-1 floor inaccuracies */

2023-04-11T21:13:49Z

Fixing some off-by-1 floor inaccuracies

← Older revision		Revision as of 21:13, 11 April 2023
Line 17:		Line 17:

	:Hope this helps! Thanks!! [[User:Margotbean\|margotbean]] ([[User talk:Margotbean\|talk]]) 19:36, 11 April 2023 (UTC)		:Hope this helps! Thanks!! [[User:Margotbean\|margotbean]] ([[User talk:Margotbean\|talk]]) 19:36, 11 April 2023 (UTC)

			::Yes, perfect -- will do it all at once sometime in the next few days/weeks! Cheers. [[User:Cooperka\|Cooperka]] ([[User talk:Cooperka\|talk]])

imported>Margotbean at 19:36, 11 April 2023

2023-04-11T19:36:44Z

← Older revision		Revision as of 19:36, 11 April 2023
Line 1:		Line 1:
			{{Talkheader}}
	== Fixing some off-by-1 floor inaccuracies ==		== Fixing some off-by-1 floor inaccuracies ==

Line 10:		Line 11:

	Is this enough to justify my changes, or are you looking for something else? Thanks! [[User:Cooperka\|Cooperka]] ([[User talk:Cooperka\|talk]]) 15:56, 11 April 2023 (UTC)		Is this enough to justify my changes, or are you looking for something else? Thanks! [[User:Cooperka\|Cooperka]] ([[User talk:Cooperka\|talk]]) 15:56, 11 April 2023 (UTC)

			:Hello Cooperka! Yes, it's enough, so, yes, you can make the changes. The changes were, in fact, fine, but I need all pages to agree with each other. So, if you could make the [[Artifacts]] page read the same as the individual pages, I wouldn't have any problems with the changes. You could also add code references (if they're not already on the page), but link to the actual code, not the github source. Anyone can decompile the game code with ILSpy, so referring to a <samp>class::method</samp> in the game code is better than a link to github.

			:I believe all required references are on the [[Artifacts]] page already, so adding to the individual pages is what I'd be looking for.

			:Hope this helps! Thanks!! [[User:Margotbean\|margotbean]] ([[User talk:Margotbean\|talk]]) 19:36, 11 April 2023 (UTC)

imported>Cooperka: fix code block

2023-04-11T15:56:55Z

fix code block

← Older revision		Revision as of 15:56, 11 April 2023
Line 5:		Line 5:
	The edits were reverted with no explanation, so I'd like to add more context here and get feedback from Margotbean on whether it's enough to justify making the changes. I now realize this [[Artifacts]] page also has the same inaccuracies, so if approved, I'll make the edits here along with the specific item pages.		The edits were reverted with no explanation, so I'd like to add more context here and get feedback from Margotbean on whether it's enough to justify making the changes. I now realize this [[Artifacts]] page also has the same inaccuracies, so if approved, I'll make the edits here along with the specific item pages.

	The relevant source code is [https://github.com/veywrn/StardewValley/blob/master/StardewValley/Locations/MineShaft.cs#L2695 here] for the item with [https://stardewids.com/ item code] 96 ([[Dwarf Scroll I]]) which does not depend on floor number; and [https://github.com/veywrn/StardewValley/blob/master/StardewValley/Locations/MineShaft.cs#L2713 here] for items 97 ([[Dwarf Scroll II]]), 99 ([[Dwarf Scroll IV]]), 121 ([[Dwarvish Helm]]), 122 ([[Dwarf Gadget]]), etc. which do depend on floor number: <code>case 40:<code> is code for changing the type of item which is possible to receive upon entering floor 40.		The relevant source code is [https://github.com/veywrn/StardewValley/blob/master/StardewValley/Locations/MineShaft.cs#L2695 here] for the item with [https://stardewids.com/ item code] 96 ([[Dwarf Scroll I]]) which does not depend on floor number; and [https://github.com/veywrn/StardewValley/blob/master/StardewValley/Locations/MineShaft.cs#L2713 here] for items 97 ([[Dwarf Scroll II]]), 99 ([[Dwarf Scroll IV]]), 121 ([[Dwarvish Helm]]), 122 ([[Dwarf Gadget]]), etc. which do depend on floor number: <code>case 40:</code> is code for changing the type of item which is possible to receive upon entering floor 40.

	Similarly, as described in [[The_Mines#Floors]], the environment drastically changes on floors 40, 70, 80, 110, etc. so my proposed fix seems to align with the existing Mines wiki too: things are different between floor 39 and 40, rather than being different between floor 40 and 41.		Similarly, as described in [[The_Mines#Floors]], the environment drastically changes on floors 40, 70, 80, 110, etc. so my proposed fix seems to align with the existing Mines wiki too: things are different between floor 39 and 40, rather than being different between floor 40 and 41.

	Is this enough to justify my changes, or are you looking for something else? Thanks! [[User:Cooperka\|Cooperka]] ([[User talk:Cooperka\|talk]]) 15:56, 11 April 2023 (UTC)		Is this enough to justify my changes, or are you looking for something else? Thanks! [[User:Cooperka\|Cooperka]] ([[User talk:Cooperka\|talk]]) 15:56, 11 April 2023 (UTC)

imported>Cooperka: /* Fixing some off-by-1 floor inaccuracies */ new section

2023-04-11T15:56:35Z

Fixing some off-by-1 floor inaccuracies: new section

New page

== Fixing some off-by-1 floor inaccuracies ==

I recently made some edits to several specific artifact pages (such as [[Dwarvish Helm]]) to fix what I believe to be inaccuracies in the mine floors they can found on when tilling (for example, it should say floors 1-39 rather than floors 1-40, because the item cannot be found on floor 40 even if the soil were tillable).

The edits were reverted with no explanation, so I'd like to add more context here and get feedback from Margotbean on whether it's enough to justify making the changes. I now realize this [[Artifacts]] page also has the same inaccuracies, so if approved, I'll make the edits here along with the specific item pages.

The relevant source code is [https://github.com/veywrn/StardewValley/blob/master/StardewValley/Locations/MineShaft.cs#L2695 here] for the item with [https://stardewids.com/ item code] 96 ([[Dwarf Scroll I]]) which does not depend on floor number; and [https://github.com/veywrn/StardewValley/blob/master/StardewValley/Locations/MineShaft.cs#L2713 here] for items 97 ([[Dwarf Scroll II]]), 99 ([[Dwarf Scroll IV]]), 121 ([[Dwarvish Helm]]), 122 ([[Dwarf Gadget]]), etc. which do depend on floor number: <code>case 40:<code> is code for changing the type of item which is possible to receive upon entering floor 40.

Similarly, as described in [[The_Mines#Floors]], the environment drastically changes on floors 40, 70, 80, 110, etc. so my proposed fix seems to align with the existing Mines wiki too: things are different between floor 39 and 40, rather than being different between floor 40 and 41.

Is this enough to justify my changes, or are you looking for something else? Thanks! [[User:Cooperka|Cooperka]] ([[User talk:Cooperka|talk]]) 15:56, 11 April 2023 (UTC)