Talk:Curiosity Lure - Revision history

imported>User314159 at 17:50, 31 December 2021

2021-12-31T17:50:10Z

← Older revision		Revision as of 17:50, 31 December 2021
Line 28:		Line 28:

	::::I'm fine if we want to replace the "fish affected by location" with something else. I originally added that section because I wanted to list out exactly which fish were affected. When I came to this page all it said was that it "increases your chance to catch rare fish" without specifying which exact fish it affected. So I looked through the code to see which fish were affected, but then I noticed that there was some sort of global effect on catching fish. As best as I could tell it just made trash less likely to be caught, but I didn't attempt to figure out exact numbers. My preference is that we make sure every named fish that this directly affects is still named. BlaDe your spreadsheet is awesome, and Margotbean thanks for always looking to help on this wiki. Again, I haven't tried to figure out the math on how much chances already go up, so I'll leave it to the editors who have done that work on how that should be conveyed. [[User:Biochromatic\|Biochromatic]] ([[User talk:Biochromatic\|talk]]) 17:36, 31 December 2021 (UTC)		::::I'm fine if we want to replace the "fish affected by location" with something else. I originally added that section because I wanted to list out exactly which fish were affected. When I came to this page all it said was that it "increases your chance to catch rare fish" without specifying which exact fish it affected. So I looked through the code to see which fish were affected, but then I noticed that there was some sort of global effect on catching fish. As best as I could tell it just made trash less likely to be caught, but I didn't attempt to figure out exact numbers. My preference is that we make sure every named fish that this directly affects is still named. BlaDe your spreadsheet is awesome, and Margotbean thanks for always looking to help on this wiki. Again, I haven't tried to figure out the math on how much chances already go up, so I'll leave it to the editors who have done that work on how that should be conveyed. [[User:Biochromatic\|Biochromatic]] ([[User talk:Biochromatic\|talk]]) 17:36, 31 December 2021 (UTC)

			:::::I see, that makes sense. I agree that we should definitely keep the fish it directly affects still named. However, instead of sorting it by location, I think we should sort it by type (I described it above earlier). Sorting it by location is confusing and reads as if only those fish in those areas get affected, even though the global effect confirms that is not true. [[User:User314159\|User314159]] ([[User talk:User314159\|talk]]) 17:50, 31 December 2021 (UTC)

imported>Biochromatic: /* Inaccurate information */

2021-12-31T17:37:38Z

Inaccurate information

← Older revision		Revision as of 17:37, 31 December 2021
Line 26:		Line 26:

	:::I don't think the "fish affected by location" section is necessary. This is because all of the fish there fall into 3 categories: 1) legendary fish, 2) night market fish, and 3) mines fish, whose calculations depend directly in the getFish command in the game code. It is much easier to merge that section with the "specific calculations" section. I'd also expand the "global effects" section to make it clear that all fish are affected in some way, because with the way it is currently presented it is kind of easy to overlook it. [[User:User314159\|User314159]] ([[User talk:User314159\|talk]]) 15:31, 31 December 2021 (UTC)		:::I don't think the "fish affected by location" section is necessary. This is because all of the fish there fall into 3 categories: 1) legendary fish, 2) night market fish, and 3) mines fish, whose calculations depend directly in the getFish command in the game code. It is much easier to merge that section with the "specific calculations" section. I'd also expand the "global effects" section to make it clear that all fish are affected in some way, because with the way it is currently presented it is kind of easy to overlook it. [[User:User314159\|User314159]] ([[User talk:User314159\|talk]]) 15:31, 31 December 2021 (UTC)

			::::I'm fine if we want to replace the "fish affected by location" with something else. I originally added that section because I wanted to list out exactly which fish were affected. When I came to this page all it said was that it "increases your chance to catch rare fish" without specifying which exact fish it affected. So I looked through the code to see which fish were affected, but then I noticed that there was some sort of global effect on catching fish. As best as I could tell it just made trash less likely to be caught, but I didn't attempt to figure out exact numbers. My preference is that we make sure every named fish that this directly affects is still named. BlaDe your spreadsheet is awesome, and Margotbean thanks for always looking to help on this wiki. Again, I haven't tried to figure out the math on how much chances already go up, so I'll leave it to the editors who have done that work on how that should be conveyed. [[User:Biochromatic\|Biochromatic]] ([[User talk:Biochromatic\|talk]]) 17:36, 31 December 2021 (UTC)

imported>User314159 at 15:31, 31 December 2021

2021-12-31T15:31:21Z

← Older revision		Revision as of 15:31, 31 December 2021
Line 24:		Line 24:

	::I think the best thing to do is to rewrite the "rare fish not affected" section entirely. I'd remove the Scorpion Carp example but keep the Octopus one (the reason for keeping the Octopus one is because 1) it is not increased on the submarine (in fact, it decreases) and 2) to reinforce the fact that it is still affected on The Beach/Ginger Island West due to the global bite rate discussed in the first section). The Glacierfish example is accurate regardless because of the explicit Legendary Fish hook chances. [[User:User314159\|User314159]] ([[User talk:User314159\|talk]]) 15:06, 31 December 2021 (UTC)		::I think the best thing to do is to rewrite the "rare fish not affected" section entirely. I'd remove the Scorpion Carp example but keep the Octopus one (the reason for keeping the Octopus one is because 1) it is not increased on the submarine (in fact, it decreases) and 2) to reinforce the fact that it is still affected on The Beach/Ginger Island West due to the global bite rate discussed in the first section). The Glacierfish example is accurate regardless because of the explicit Legendary Fish hook chances. [[User:User314159\|User314159]] ([[User talk:User314159\|talk]]) 15:06, 31 December 2021 (UTC)

			:::I don't think the "fish affected by location" section is necessary. This is because all of the fish there fall into 3 categories: 1) legendary fish, 2) night market fish, and 3) mines fish, whose calculations depend directly in the getFish command in the game code. It is much easier to merge that section with the "specific calculations" section. I'd also expand the "global effects" section to make it clear that all fish are affected in some way, because with the way it is currently presented it is kind of easy to overlook it. [[User:User314159\|User314159]] ([[User talk:User314159\|talk]]) 15:31, 31 December 2021 (UTC)

imported>User314159 at 15:06, 31 December 2021

2021-12-31T15:06:30Z

← Older revision		Revision as of 15:06, 31 December 2021
Line 22:		Line 22:
	I'm not sure on the best way to convey this on the page, so will leave this here and have another look in a few days.[[User:BlaDe\|BlaDe]] ([[User talk:BlaDe\|talk]]) 08:33, 31 December 2021 (UTC)		I'm not sure on the best way to convey this on the page, so will leave this here and have another look in a few days.[[User:BlaDe\|BlaDe]] ([[User talk:BlaDe\|talk]]) 08:33, 31 December 2021 (UTC)
	:Thanks, BlaDe, much appreciated! Please let me know if I can offer assistance. [[User:Margotbean\|margotbean]] ([[User talk:Margotbean\|talk]]) 13:56, 31 December 2021 (UTC)		:Thanks, BlaDe, much appreciated! Please let me know if I can offer assistance. [[User:Margotbean\|margotbean]] ([[User talk:Margotbean\|talk]]) 13:56, 31 December 2021 (UTC)

			::I think the best thing to do is to rewrite the "rare fish not affected" section entirely. I'd remove the Scorpion Carp example but keep the Octopus one (the reason for keeping the Octopus one is because 1) it is not increased on the submarine (in fact, it decreases) and 2) to reinforce the fact that it is still affected on The Beach/Ginger Island West due to the global bite rate discussed in the first section). The Glacierfish example is accurate regardless because of the explicit Legendary Fish hook chances. [[User:User314159\|User314159]] ([[User talk:User314159\|talk]]) 15:06, 31 December 2021 (UTC)

imported>Margotbean at 13:56, 31 December 2021

2021-12-31T13:56:26Z

← Older revision		Revision as of 13:56, 31 December 2021
Line 1:		Line 1:
			{{Talkheader}}
	==Inaccurate information==		==Inaccurate information==
	The page claims that the lure affects all fish, while also claiming specific fish that it doesn't affect.		The page claims that the lure affects all fish, while also claiming specific fish that it doesn't affect.
Line 20:		Line 21:

	I'm not sure on the best way to convey this on the page, so will leave this here and have another look in a few days.[[User:BlaDe\|BlaDe]] ([[User talk:BlaDe\|talk]]) 08:33, 31 December 2021 (UTC)		I'm not sure on the best way to convey this on the page, so will leave this here and have another look in a few days.[[User:BlaDe\|BlaDe]] ([[User talk:BlaDe\|talk]]) 08:33, 31 December 2021 (UTC)
			:Thanks, BlaDe, much appreciated! Please let me know if I can offer assistance. [[User:Margotbean\|margotbean]] ([[User talk:Margotbean\|talk]]) 13:56, 31 December 2021 (UTC)

imported>BlaDe: Created page with "==Inaccurate information== The page claims that the lure affects all fish, while also claiming specific fish that it doesn't affect. The way it affects legendary fish and nig..."

2021-12-31T08:33:36Z

Created page with "==Inaccurate information== The page claims that the lure affects all fish, while also claiming specific fish that it doesn't affect. The way it affects legendary fish and nig..."

New page

==Inaccurate information==
The page claims that the lure affects all fish, while also claiming specific fish that it doesn't affect.

The way it affects legendary fish and night market fish is explicit in the code, and done before any other fish is considered, so these are accurate.

The way it affects hooking fish in the general fish pool for the location is wildly inaccurate.

When hooking a fish in the general fish pool, the game calculates a specific bite chance for the fish being evaluated. This has a base chance set in the Fish json file, and gets reduced if the fishing zone is less than the ideal zone, also set in the Fish json file. 0.5% is added per fishing level.

If this resulting % is less than 25%, then the curiosity lure will buff this hook chance.
<code>
float max = 0.25f;
float min = 0.08f;
chance = (double)((max - min) / max) * chance + (double)((max - min) / 2f);
</code>

Due to the number of factors involved in calculating the initial chance, it is possible for a fish to be affected in some scenarios, and to have no affect in others. However both the scorpian carp and the octopus can be hooked in scenarios where the curiosity lure has an affect.

My fish pond calculation sheet can be used to determine the initial chance, and it even has an option for the curiosity lure. https://docs.google.com/spreadsheets/d/1HRc2zsEz-Ar_EFyS28HhNNXwGmq5Ilg9DJq12mZqDYk/edit#gid=1064308719

I'm not sure on the best way to convey this on the page, so will leave this here and have another look in a few days.[[User:BlaDe|BlaDe]] ([[User talk:BlaDe|talk]]) 08:33, 31 December 2021 (UTC)