User:Pathoschild/Modding wishlist/Completed - Revision history

imported>Pathoschild: /* Small changes */ remove list of accessibility modifier changes (very incomplete, too many to reasonably list here)

2023-04-20T03:07:20Z

Small changes: remove list of accessibility modifier changes (very incomplete, too many to reasonably list here)

@@ Line 567: / Line 567: @@
 * ☑ Change <samp>IslandLocation.DrawParallaxHorizon</samp> to support custom sunset times that aren't on the hour, by using <samp>Utility.CalculateMinutesBetweenTimes</samp> instead of calculating the time manually.
 * ☑ Remove <samp>Woods.stumps</samp> and use the new <samp>location.resourceClumps</samp> field instead.
-<ul>
+* ☑ Tweak accessibility modifiers. <small>(Stardew Valley 1.6 marks a large number of methods <samp>virtual</samp> and <samp>public</samp>/<samp>protected</samp>, too many to list here.)</small>
 ===Medium changes===

imported>Pathoschild: /* Small changes */ + virtual IClickableText.populateClickableComponentList method, fix typo & order

2023-03-12T16:34:33Z

Small changes: + virtual IClickableText.populateClickableComponentList method, fix typo & order

← Older revision		Revision as of 16:34, 12 March 2023
Line 598:		Line 598:
	* add <samp>ClearCachedConcessionTastes()</samp> method to reset <samp>_concessionTastes</samp>.		* add <samp>ClearCachedConcessionTastes()</samp> method to reset <samp>_concessionTastes</samp>.
	\|-		\|-
	\| <samp>~~Locations~~\ForgeMenu</samp>		\| <samp>Menus\ForgeMenu</samp>
	\|		\|
	* make methods virtual: <samp>CraftItem</samp>, <samp>GenerateHighlightDictionary</samp>, <samp>IsValidCraft</samp>, and <samp>IsValidCraftIngredient</samp>.		* make methods virtual: <samp>CraftItem</samp>, <samp>GenerateHighlightDictionary</samp>, <samp>IsValidCraft</samp>, and <samp>IsValidCraftIngredient</samp>.
	\|-		\|-
	\| <samp>Menus\~~JunimoNoteMenu~~</samp>		\| <samp>Menus\IClickableText</samp>
	\|		\|
	* make ~~fields public~~: <samp>~~heldItem</samp>, <samp>hoveredItem~~</samp>.		* make method virtual: <samp>populateClickableComponentList</samp>.
	\|-		\|-
	\| <samp>Menus\InventoryPage</samp>		\| <samp>Menus\InventoryPage</samp>
Line 613:		Line 613:
	\|		\|
	* make field public: <samp>sourceItem</samp>.		* make field public: <samp>sourceItem</samp>.
			\|-
			\| <samp>Menus\JunimoNoteMenu</samp>
			\|
			* make fields public: <samp>heldItem</samp>, <samp>hoveredItem</samp>.
	\|-		\|-
	\| <samp>Menus\ShopMenu</samp>		\| <samp>Menus\ShopMenu</samp>

imported>Pathoschild: /* Done in Stardew Valley {{version|1.6}} (upcoming) */ + MineShaft fields public in 1.6.0 build 23036

2023-02-04T23:47:43Z

Done in Stardew Valley {{version|1.6}} (upcoming): + MineShaft fields public in 1.6.0 build 23036

← Older revision		Revision as of 23:47, 4 February 2023
Line 589:		Line 589:
	\|		\|
	* make fields public: <samp>Gil</samp>, <samp>talkedToGil</samp>.		* make fields public: <samp>Gil</samp>, <samp>talkedToGil</samp>.
			\|-
			\| <samp>Locations\MineShaft</samp>
			\|
			* make fields public: <samp>ambientFog</samp>, <samp>ElevatorLightSpot</samp>, <samp>fogColor</samp>, <samp>fogPos</samp>, <samp>fogTime</samp>, <samp>ghostAdded</samp>, <samp>isDinoArea</samp>, <samp>isFallingDownShaft</samp>, <samp>isFogUp</samp>, <samp>isDinoArea</samp>, <samp>isLightingDark</samp>, <samp>isMonsterArea</samp>, <samp>isQuarryArea</samp>, <samp>isSlimeArea</samp>, <samp>ladderHasSpawned</samp>, <samp>loadedDarkArea</samp>, <samp>lighting</samp>, <samp>mineRandom</samp>, <samp>rainbowLights</samp>, <samp>stonesLeftOnThisLevel</samp>, <samp>tileBeneathElevator</samp>, <samp>tileBeneathLadder</samp>.
	\|-		\|-
	\| <samp>Locations\MovieTheater</samp>		\| <samp>Locations\MovieTheater</samp>

imported>Pathoschild: /* Small changes */ + Tool.Update virtual

2023-01-23T00:17:17Z

Small changes: + Tool.Update virtual

← Older revision		Revision as of 00:17, 23 January 2023
Line 641:		Line 641:
	\|		\|
	* make methods public: <samp>resetTexture</samp>, <samp>shake</samp>.		* make methods public: <samp>resetTexture</samp>, <samp>shake</samp>.
			\|-
			\| <samp>Tool</samp>
			\|
			* make method virtual: <samp>Update</samp>.
	\|}		\|}
	</li>		</li>

imported>Pathoschild: /* Small changes */ add more public methods

2023-01-11T04:31:33Z

Small changes: add more public methods

← Older revision		Revision as of 04:31, 11 January 2023
Line 621:		Line 621:
	\|		\|
	* make fields public: <samp>currentLidFrame</samp>, <samp>frameCounter</samp>, <samp>_shippingBinFrameCounter</samp>, <samp>_farmerNearby</samp>.		* make fields public: <samp>currentLidFrame</samp>, <samp>frameCounter</samp>, <samp>_shippingBinFrameCounter</samp>, <samp>_farmerNearby</samp>.
			\|-
			\| <samp>SpecialOrder</samp>
			\|
			* make method public: <samp>CheckTag</samp>.
	\|-		\|-
	\| <samp>TemporaryAnimatedSprite</samp>		\| <samp>TemporaryAnimatedSprite</samp>
	\|		\|
	* make field public: <samp>textureName</samp>.		* make field public: <samp>textureName</samp>.
			\|-
			\| <samp>TerrainFeatures\Bush</samp>
			\|
			* make method public: <samp>shake</samp>.
			\|-
			\| <samp>TerrainFeatures\HoeDirt</samp>
			\|
			* make method public: <samp>shake</samp>.
	\|-		\|-
	\| <samp>TerrainFeatures\Tree</samp>		\| <samp>TerrainFeatures\Tree</samp>
	\|		\|
	* make ~~method~~ public: <samp>resetTexture</samp>.		* make methods public: <samp>resetTexture</samp>, <samp>shake</samp>.
	\|}		\|}
	</li>		</li>

imported>Pathoschild: /* Medium changes */ + use display name consistently in English

2022-12-04T03:18:59Z

Medium changes: + use display name consistently in English

← Older revision		Revision as of 03:18, 4 December 2022
Line 641:		Line 641:
	** ☑ <samp>Data\Furniture</samp>		** ☑ <samp>Data\Furniture</samp>
	** ☑ <samp>Data\Weapons</samp>		** ☑ <samp>Data\Weapons</samp>
			* ☑ Remove hardcoded logic that ignores display names when playing in English (e.g. for NPC gift taste dialogues). That causes a bug where renamed NPCs still show their internal name in some places.

	===Refactoring===		===Refactoring===

imported>Pathoschild: /* Done in Stardew Valley {{version|1.6}} (upcoming) */ + Data/Bundles display name in English

2022-12-04T03:18:09Z

Done in Stardew Valley {{version|1.6}} (upcoming): + Data/Bundles display name in English

← Older revision		Revision as of 03:18, 4 December 2022
Line 636:		Line 636:
	* ☑ Some XNB files have a separate display name field, but only in non-English. Using display names consistently regardless of language would let mods rename things without breaking keys:		* ☑ Some XNB files have a separate display name field, but only in non-English. Using display names consistently regardless of language would let mods rename things without breaking keys:
	** ☑ <samp>Data\Boots</samp>		** ☑ <samp>Data\Boots</samp>
			** ☑ <samp>Data\Bundles</samp>
	** ☑ <samp>Data\CraftingRecipes</samp>		** ☑ <samp>Data\CraftingRecipes</samp>
	** ☑ <samp>Data\CookingRecipes</samp>		** ☑ <samp>Data\CookingRecipes</samp>

imported>Pathoschild: /* Done in Stardew Valley {{version|1.6}} (upcoming) */ + mark classes public

2022-12-04T03:17:19Z

Done in Stardew Valley {{version|1.6}} (upcoming): + mark classes public

← Older revision		Revision as of 03:17, 4 December 2022
Line 563:		Line 563:

	===Small changes===		===Small changes===
			* ☑ Change all remaining <code>internal class</code> and <code>private class</code> to <code>public class</code> to simplify mod access.
	* ☑ Change <code>Utility.isMale(name)</code> to check the NPC info instead of a hardcoded switch, so it works with custom NPCs.		* ☑ Change <code>Utility.isMale(name)</code> to check the NPC info instead of a hardcoded switch, so it works with custom NPCs.
	* ☑ Change <samp>IslandLocation.DrawParallaxHorizon</samp> to support custom sunset times that aren't on the hour, by using <samp>Utility.CalculateMinutesBetweenTimes</samp> instead of calculating the time manually.		* ☑ Change <samp>IslandLocation.DrawParallaxHorizon</samp> to support custom sunset times that aren't on the hour, by using <samp>Utility.CalculateMinutesBetweenTimes</samp> instead of calculating the time manually.

imported>Pathoschild: /* Done in Stardew Valley {{version|1.6}} (upcoming) */ + virtual Background methods

2022-12-04T03:11:58Z

Done in Stardew Valley {{version|1.6}} (upcoming): + virtual Background methods

← Older revision		Revision as of 03:11, 4 December 2022
Line 572:		Line 572:
	! class		! class
	! changes		! changes
			\|-
			\| <samp>Background</samp>
			\|
			* make methods virtual: <samp>draw</samp>, <samp>update</samp>.
	\|-		\|-
	\| <samp>BellsAndWhistles\SpriteText</samp>		\| <samp>BellsAndWhistles\SpriteText</samp>

imported>Pathoschild: /* Small changes */ + SpriteText public fields

2022-12-03T03:49:31Z

Small changes: + SpriteText public fields

← Older revision		Revision as of 03:49, 3 December 2022
Line 572:		Line 572:
	! class		! class
	! changes		! changes
			\|-
			\| <samp>BellsAndWhistles\SpriteText</samp>
			\|
			* make fields public: <samp>characterMap</samp>, <samp>FontFile</samp>, <samp>fontPages</samp>.
	\|-		\|-
	\| <samp>FarmerRenderer</samp>		\| <samp>FarmerRenderer</samp>