|
|
| (3 intermediate revisions by the same user not shown) |
| Line 6: |
Line 6: |
|
| |
|
| ===Small changes=== | | ===Small changes=== |
| * ☐ Change all remaining <code>internal class</code> and <code>private class</code> to <code>public class</code> to simplify mod access.
| | ''All done!'' |
| <ul>
| |
| <li>☐ Change the logic in <samp>IslandLocation.DrawParallaxHorizon</samp> to support custom sunset times that aren't on the hour. Specifically:
| |
| <syntaxhighlight lang="c#">
| |
| // before
| |
| float day_night_transition = Utility.ConvertTimeToMinutes(Game1.timeOfDay + (int)((float)Game1.gameTimeInterval / 7000f * 10f % 10f) - Game1.getStartingToGetDarkTime()) / (float)Utility.ConvertTimeToMinutes(Game1.getTrulyDarkTime() - Game1.getStartingToGetDarkTime());
| |
| | |
| // after
| |
| float day_night_transition = Utility.CalculateMinutesBetweenTimes(Game1.getStartingToGetDarkTime(), (Game1.timeOfDay + (int)(Game1.gameTimeInterval / 7000f * 10f % 10f))) / (float)Utility.CalculateMinutesBetweenTimes(Game1.getStartingToGetDarkTime(), Game1.getTrulyDarkTime());
| |
| </syntaxhighlight></li>
| |
| <li>☐ Make methods virtual:
| |
| {| class="wikitable"
| |
| |-
| |
| ! class | |
| ! methods
| |
| |-
| |
| | <samp>Background</samp>
| |
| | <samp>draw</samp>, <samp>update</samp>
| |
| |}</li>
| |
| </ul>
| |
|
| |
|
| ===Medium changes=== | | ===Medium changes=== |
| * ☐ Add map property for default warp location (e.g. <samp>Utility.getDefaultWarpLocation</samp>). | | * ☐ Add map property for default warp location (e.g. <samp>Utility.getDefaultWarpLocation</samp>). |
| * ☐ Some XNB files have a separate display name field, but only in non-English. Using display names consistently regardless of language would let mods rename things without breaking keys:
| |
| ** ☐ <samp>Data\Bundles</samp>
| |
| * ☐ Remove hardcoded logic that ignores display names when playing in English (e.g. for NPC gift taste dialogues); can search <code>LocalizedContentManager.LanguageCode.en</code> to find many of them. That causes a bug where renamed NPCs still show their internal name in some places.
| |
|
| |
|
| ===Refactoring=== | | ===Refactoring=== |
Latest revision as of 03:19, 4 December 2022
A list of requested changes in the game code to support modders. This list does not include complex refactoring or rewriting, which is unlikely to be accepted.
Wishlist
Bug fixes
All done!
Small changes
All done!
Medium changes
- ☐ Add map property for default warp location (e.g. Utility.getDefaultWarpLocation).
Refactoring
- ☐ Change all
const fields to static readonly. They're accessed the same way and the performance difference is negligible, but that'll make the decompiled code much easier to understand, and avoid issues where const values get 'baked in' to mod assemblies.
Completed items
See the list of items completed in previous game versions.
